Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .git-blame-ignore-revs #8386

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jan 24, 2024

Description

With the context coming from this thread on the company slack: https://consensys.slack.com/archives/GTQAGKY5V/p1706061509793679?thread_ts=1706052972.337199&cid=GTQAGKY5V

This PR adds for the first time a .git-blame-ignore-revs file: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

The only revision added to this file is this commit bdb7f37, coming from this refactor #4182 by @rekmarks

Revisions added:

  1. 57afe4c from Add typescript eslint from metamask #3088
  2. bdb7f37 from Standardize prettier configuration #4182

Related issues

no issue related

Manual testing steps

no steps

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jan 24, 2024
@wachunei wachunei requested a review from a team as a code owner January 24, 2024 18:33
@wachunei
Copy link
Member Author

I'm thinking about adding 57afe4c from #3088

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b42d47) 40.44% compared to head (74ace1c) 40.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8386   +/-   ##
=======================================
  Coverage   40.44%   40.44%           
=======================================
  Files        1239     1239           
  Lines       29975    29975           
  Branches     2875     2875           
=======================================
  Hits        12122    12122           
  Misses      17156    17156           
  Partials      697      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wachunei wachunei merged commit e45d196 into main Jan 25, 2024
26 checks passed
@wachunei wachunei deleted the chore/add-blame-ignore-revs branch January 25, 2024 18:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 25, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants