Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Blockaid] Cosmetic issue on "before you proceed" sheet #8394

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

blackdevelopa
Copy link
Contributor

Description

This PR

  1. Updates copy before enabling blockaid
  2. Align the success icon to the centre when blockaid is enabled

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1508

Manual testing steps

  1. Go to Experimental screen
  2. Toggle blockaid on
  3. Wait for blockaid to be enabled
  4. See success icon not centered

Screenshots/Recordings

Before

https://recordit.co/AFoMS9YoUj

After

https://recordit.co/Cqkbxkb8Yz

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@blackdevelopa blackdevelopa requested a review from a team as a code owner January 25, 2024 07:35
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Jan 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b66c53) 40.35% compared to head (86aa753) 40.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8394   +/-   ##
=======================================
  Coverage   40.35%   40.35%           
=======================================
  Files        1236     1236           
  Lines       29985    29985           
  Branches     2879     2879           
=======================================
  Hits        12100    12100           
  Misses      17190    17190           
  Partials      695      695           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@blackdevelopa blackdevelopa merged commit b2b2553 into main Jan 25, 2024
29 of 30 checks passed
@blackdevelopa blackdevelopa deleted the blockaid_copy_fix branch January 25, 2024 13:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 25, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants