Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockaid experimental settings should be visible on all networks #8412

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 26, 2024

Description

Blockaid experimental settings should be visible on all networks

Related issues

Fixes: #8411

Manual testing steps

  1. Switch to Goreli network
  2. Go to experimental settings
  3. Option to enable blockaid should be visible

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 26, 2024
@jpuri jpuri requested a review from a team as a code owner January 26, 2024 13:27
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/588b75da-4f34-4cdb-8dbe-5660cc4c7af3
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea21001) 40.43% compared to head (86d48d5) 40.44%.

❗ Current head 86d48d5 differs from pull request most recent head 0916416. Consider uploading reports for the commit 0916416 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8412      +/-   ##
==========================================
+ Coverage   40.43%   40.44%   +0.01%     
==========================================
  Files        1239     1239              
  Lines       29976    29971       -5     
  Branches     2875     2869       -6     
==========================================
+ Hits        12122    12123       +1     
  Misses      17157    17157              
+ Partials      697      691       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 26, 2024

@seaona seaona added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 26, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4f776daa-6836-4605-bc7e-0bc6fe56abeb
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@jpuri jpuri merged commit d2e926e into main Jan 26, 2024
29 checks passed
@jpuri jpuri deleted the blockaid_fix branch January 26, 2024 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 26, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Experimenal Settings for Blockaid disappear when a non-supported network is selected
6 participants