Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch unfulfilled promise for token fetch #8415

Merged
merged 1 commit into from
Jan 27, 2024
Merged

fix: catch unfulfilled promise for token fetch #8415

merged 1 commit into from
Jan 27, 2024

Conversation

frankvonhoven
Copy link
Contributor

Description

When a token's price is unavailable, the list of token prices becomes unavailable. On pull to refresh this was resulting with a hung spinner due to an uncaught promise rejection.
This PR adds a catch to the promise to resolve the hanging spinner.

Related issues

Related: #1518

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2024-01-26.at.15.32.29.mp4

After

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2024-01-26.at.15.29.53.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven requested a review from a team as a code owner January 26, 2024 21:33
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven added team-mobile-client No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Jan 26, 2024
@chrisleewilcox chrisleewilcox removed the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Jan 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chrisleewilcox chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA in Progress QA has started on the feature. Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited by chrisleewilcox

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f754ce7b-d569-4495-b40f-3ce23625c850
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1884c885-3fb3-4396-9024-559337945b17

@chrisleewilcox
Copy link
Contributor

Android and iOS simulator...

https://recordit.co/vZDew6gNqb

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA in Progress QA has started on the feature. labels Jan 27, 2024
chrisleewilcox
chrisleewilcox approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 266154a into main Jan 27, 2024
43 of 44 checks passed
@chrisleewilcox chrisleewilcox deleted the bug/1518-swipe-refresh-spinner branch January 27, 2024 00:55
@chrisleewilcox chrisleewilcox self-assigned this Jan 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@sethkfman sethkfman Awaiting requested review from sethkfman

Assignees

@chrisleewilcox chrisleewilcox

Labels
QA Passed A successful QA run through has been done release-7.16.0 Issue or pull request that will be included in release 7.16.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frankvonhoven @chrisleewilcox @gauthierpetetin @metamaskbot