refactor: QOL update for BottomSheet and BottomSheetDialog

[brianacnguyen]

Description

• Aligned onDismiss/onClose/onHidden to onClose-related functions
• Added onOpen functions
• Added more comments to BottomSheetDialog logic and updated const names to be more intuitive
• Added test to BottomSheetDialog

Related issues

Fixes: N/A

Manual testing steps

1. Change pointer to Storybook in index.js
2. Open app
3. Click on Component Library -> BottomSheet

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-28.at.18.43.44.mp4

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (97682bc) 40.41% compared to head (a7b3c60) 40.52%.

Files	Patch %	Lines
...foundation/BottomSheetDialog/BottomSheetDialog.tsx	50.00%	15 Missing ⚠️
...omponents/BottomSheets/BottomSheet/BottomSheet.tsx	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8437      +/-   ##
==========================================
+ Coverage   40.41%   40.52%   +0.11%     
==========================================
  Files        1239     1239              
  Lines       29974    29978       +4     
  Branches     2868     2868              
==========================================
+ Hits        12114    12150      +36     
+ Misses      17168    17133      -35     
- Partials      692      695       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[georgewrmarshall]

LGTM!

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
30.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud