-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ramp): add routes folder #8457
Conversation
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c5197b52-eb6d-480a-9cb8-5e1ab237d448 |
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8457 +/- ##
=======================================
Coverage 40.62% 40.62%
=======================================
Files 1239 1240 +1
Lines 29989 29989
Branches 2870 2870
=======================================
Hits 12182 12182
Misses 17109 17109
Partials 698 698 ☔ View full report in Codecov by Sentry. |
|
@wachunei LGTM I finished verifying ✅ |
Description
This PR adds a
routes
folder insideRamp
experience folder. Related to this channel and effort :https://consensys.slack.com/archives/C062YJBAAEA/p1706108478487099Related issues
Fixes:Manual testing steps
Navigating to Ramp experiences must have no impact.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist