Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in en.json #8460

Merged
merged 3 commits into from
Jan 29, 2024
Merged

fix: typos in en.json #8460

merged 3 commits into from
Jan 29, 2024

Conversation

frankvonhoven
Copy link
Contributor

Description

This fixes various typos in en.json

Related issues

Original external PR: #7994

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client labels Jan 29, 2024
@frankvonhoven frankvonhoven requested a review from a team as a code owner January 29, 2024 20:42
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 29, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3e38bd4-2ec3-4770-8b04-91c13340faf2
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sethkfman sethkfman added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 29, 2024
@sethkfman sethkfman changed the base branch from temp/external-pr-7994 to main January 29, 2024 22:10
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a72a9dc) 40.42% compared to head (e92944b) 40.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8460   +/-   ##
=======================================
  Coverage   40.42%   40.42%           
=======================================
  Files        1239     1239           
  Lines       29975    29975           
  Branches     2869     2869           
=======================================
  Hits        12117    12117           
  Misses      17167    17167           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 29, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ed8e87df-2ef8-4a32-a85e-c1bf36611822
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@frankvonhoven frankvonhoven merged commit 7dea6d2 into main Jan 29, 2024
29 checks passed
@frankvonhoven frankvonhoven deleted the fix/typos-in-enjson branch January 29, 2024 23:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.16.0 Issue or pull request that will be included in release 7.16.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants