-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix/8352 source map stack trace #8467
Conversation
- Make error stacks also available by the error instance stack - Preserve error stack filtered content - Like we do in metamask-extension - Improve error debugging in Sentry https://github.com/endojs/endo/blob/master/packages/ses/docs/reference.md#options-quick-reference https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/lockdown-run.js#L6
- Show full raw error info for each deep stack lvl - Preserve 'noise' that the default 'concise' option removes - Improve error debugging in Sentry https://github.com/endojs/endo/blob/master/packages/ses/docs/reference.md#options-quick-reference
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/445f3f6f-737f-424b-a5f4-908b6edae042 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
These changes fixes incorrect stack traces for errors on Sentry. Changes include:
SENTRY_DISABLE_AUTO_UPLOAD = false
Future improvements
Logger
class withbeforeSend
andbeforeBreadcrumbs
in Sentry configurationRelated issues
Fixes:
Manual testing steps
Note: Reference your own Sentry instance to see results. These tests focuses on having correct source maps as well as debug files uploaded to Sentry.
SENTRY_DISABLE_AUTO_UPLOAD
env var to "false"Screenshots/Recordings
Before
Broken stack traces
After
Accurate stack traces
Caveat: Some errors may show with
ses
as the top level stack trace. We are working towards eliminating that layer so the error is more explicit. Drilling into the error still shows the correct trace so this is a non-blockerPre-merge author checklist
Pre-merge reviewer checklist