Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify cancel gas rate of Transaction Controller #8483

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

OGPoyraz
Copy link
Member

Description

This PR aims to update transaction controller cancelTransaction gas rate update from 1.5 to 1.1 in order to align it with extension

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1928

Manual testing steps

NA

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner January 31, 2024 13:38
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8dfb349-be6e-4bf2-9730-9c6633c59570
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@OGPoyraz
Copy link
Member Author

OGPoyraz commented Feb 5, 2024

Hey @sleepytanya, it's just a small gas fee rate change but would be nice to get your approval here

@OGPoyraz OGPoyraz merged commit edb7114 into main Feb 7, 2024
29 of 30 checks passed
@OGPoyraz OGPoyraz deleted the modify-cancel-rate branch February 7, 2024 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants