Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify cherry pick action inputs #8500

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Feb 1, 2024

Description

It's not obvious that the first branch input has to be where we want the cherry picker PR to be merged in. The "based on" term is ambiguous.

Fix:

  • clarify branch field description

Related issues

Fixes: NA

Manual testing steps

  1. Go to create cherry pick PR action and check fields names

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

- clarify branch field description
- add number constraint on PR # field
@NicolasMassart NicolasMassart added Code Impact - Low Minor code change that can safely applied to the codebase team-mobile-platform labels Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart marked this pull request as ready for review February 1, 2024 12:33
@NicolasMassart NicolasMassart requested a review from a team as a code owner February 1, 2024 12:33
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9a9e04d3-eeb2-4a5d-b1e1-8fbfb4664b37
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@NicolasMassart NicolasMassart merged commit 3be5f37 into main Feb 1, 2024
27 checks passed
@NicolasMassart NicolasMassart deleted the fix/gh_action_cherrypick_inputs branch February 1, 2024 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Impact - Low Minor code change that can safely applied to the codebase release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants