-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove isFullscreen from AddAccount, AccountPermissions, and AddChainApproval #8504
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0. |
Description
isFullscreen
from AddAccount, AccountPermissions, and AddChainApproval so the view can dynamically grow to maxHeight instead of setting it to maxHeightRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-01.at.09.18.19.mp4
After
https://github.com/MetaMask/metamask-mobile/assets/14355083/eb37c70b-e6c9-4aa9-b4d8-48aadcb9fed1
https://github.com/MetaMask/metamask-mobile/assets/14355083/1133ad7f-d098-40ab-b05c-219be50cad3b
https://github.com/MetaMask/metamask-mobile/assets/14355083/5c91f31d-bca3-4c56-aa5c-f835df3bca03
Pre-merge author checklist
Pre-merge reviewer checklist