-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix/8352 source map stack trace #8509
Conversation
- Make error stacks also available by the error instance stack - Preserve error stack filtered content - Like we do in metamask-extension - Improve error debugging in Sentry https://github.com/endojs/endo/blob/master/packages/ses/docs/reference.md#options-quick-reference https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/lockdown-run.js#L6
- Show full raw error info for each deep stack lvl - Preserve 'noise' that the default 'concise' option removes - Improve error debugging in Sentry https://github.com/endojs/endo/blob/master/packages/ses/docs/reference.md#options-quick-reference
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
e2e1d26
to
6ef4720
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8509 +/- ##
==========================================
- Coverage 40.67% 40.66% -0.01%
==========================================
Files 1240 1240
Lines 30011 30013 +2
Branches 2870 2870
==========================================
Hits 12206 12206
- Misses 17107 17109 +2
Partials 698 698 ☔ View full report in Codecov by Sentry. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@sentry/react-native@5.8.1, npm/stack-beautifier@1.0.2 |
…to fix/8352-source-map-stack-trace
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8822a127-24bd-4d4a-b6f2-26802c001cd1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0. |
Description
These changes fixes incorrect stack traces for errors on Sentry. Changes include:
SENTRY_DISABLE_AUTO_UPLOAD = false
Future improvements
Logger
class withbeforeSend
andbeforeBreadcrumbs
in Sentry configurationRelated issues
Fixes:
Manual testing steps
Note: Reference your own Sentry instance to see results. These tests focuses on having correct source maps as well as debug files uploaded to Sentry.
SENTRY_DISABLE_AUTO_UPLOAD
env var to "false"Screenshots/Recordings
Before
Broken stack traces
After
Accurate stack traces
Caveat: Some errors may show with
ses
as the top level stack trace. We are working towards eliminating that layer so the error is more explicit. Drilling into the error still shows the correct trace so this is a non-blockerPre-merge author checklist
Pre-merge reviewer checklist