Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update MixPanel proxy URL #8517

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

NicholasEllul
Copy link
Contributor

@NicholasEllul NicholasEllul commented Feb 2, 2024

Description

This PR updates the MixPanel proxy URL to use the updated production server domain instead. We should no longer be using the dev server.

Related issues

No related issues.

Manual testing steps

  1. You can test the proxy server is up by running the following command in your terminal (project token in invalid)
curl -i -s -k -X $'POST' \
    -H $'Host: proxy.api.cx.metamask.io' -H $'Accept: application/json' -H $'Content-Type: application/json' -H $'Content-Length: 30' \
    --data-binary $'{\"distinct_ids\": [\"12312312\"]}' \
    $'https://proxy.api.cx.metamask.io/mixpanel/v1/api/app/data-deletions/v3.0/?token=abcdefg'
  1. In the MetaMask application, navigate Settings -> Security & Privacy -> Delete MetaMetrics Data. Upon clicking you should see a request made.

Screenshots/Recordings

Before

Not applicable

After

Not applicable

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've included manual testing steps
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicholasEllul NicholasEllul changed the title Update mixpanel proxy URL fix: Update MixPanel proxy URL Feb 2, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b5d647) 40.66% compared to head (1bdc118) 40.67%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8517   +/-   ##
=======================================
  Coverage   40.66%   40.67%           
=======================================
  Files        1240     1240           
  Lines       30013    30010    -3     
  Branches     2870     2870           
=======================================
  Hits        12206    12206           
+ Misses      17109    17106    -3     
  Partials      698      698           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 2, 2024

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/22678c2b-6068-458f-8ec6-f3e1417c311a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@NicholasEllul NicholasEllul merged commit 2fd956c into main Feb 6, 2024
35 of 37 checks passed
@NicholasEllul NicholasEllul deleted the ellul/update-mixpanel-proxy branch February 6, 2024 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants