Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Feature/1300 dapp visit event #8520

Merged
merged 13 commits into from
Feb 15, 2024
Merged

feat: Feature/1300 dapp visit event #8520

merged 13 commits into from
Feb 15, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Feb 5, 2024

Description

This change tracks a new event named Dapp Visited under the four conditions listed in the original ticket

Related issues

Fixes:

Manual testing steps

Referencing the video below:
Dapp visited event should be triggered when:

  • Connecting to a dapp when no accounts are connected
  • Reloading a dapp that already has connected accounts
  • Navigating to another dapp with existing connected accounts

Original scenarios here - https://github.com/MetaMask/mobile-planning/issues/1300#:~:text=the%20first%20connection.-,Scenario,-Scenario%3A%20Dapp

Screenshots/Recordings

Before

After

This video show cases all of the scenarios listed in the original ticket

Screen.Recording.2024-02-08.at.10.21.39.PM.mov

On Mixpanel
image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L changed the title feature: Feature/1300 dapp visit event feat: Feature/1300 dapp visit event Feb 6, 2024
@Cal-L Cal-L marked this pull request as ready for review February 6, 2024 04:22
@Cal-L Cal-L requested a review from a team as a code owner February 6, 2024 04:22
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e3785a81-ea28-4185-888e-33e108feb85a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@Cal-L Cal-L added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (8ec9970) 41.08% compared to head (e7b542a) 41.08%.

Files Patch % Lines
app/components/Views/BrowserTab/index.js 0.00% 10 Missing ⚠️
...components/Views/AccountConnect/AccountConnect.tsx 0.00% 3 Missing ⚠️
app/reducers/browser/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8520      +/-   ##
==========================================
- Coverage   41.08%   41.08%   -0.01%     
==========================================
  Files        1245     1246       +1     
  Lines       30330    30355      +25     
  Branches     2962     2962              
==========================================
+ Hits        12462    12471       +9     
- Misses      17125    17141      +16     
  Partials      743      743              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added notes

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a question

@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 13, 2024
Copy link

sonarcloud bot commented Feb 15, 2024

@Cal-L Cal-L merged commit 23dc52b into main Feb 15, 2024
46 checks passed
@Cal-L Cal-L deleted the feature/1300-dapp-visit-event branch February 15, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 15, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants