Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added keyboard avoiding view to bottomsheetdialog #8526

Merged
merged 9 commits into from
Feb 6, 2024

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Feb 5, 2024

Description

  • The BottomSheetDialog currently does not use KeyboardAvoidView as it should've. This fix enables to bottomsheet to be visible while the keyboard is visible in a bottomsheet form

Related issues

Fixes: N/A

Manual testing steps

  1. Go to Settings
  2. Go to Advanced Settings
  3. Toggle eth sign requests
  4. Check the checkbox and continue
  5. Try to enter a text in the form

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-05.at.09.04.49.mp4

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-05.at.08.56.21.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Feb 5, 2024
@brianacnguyen brianacnguyen self-assigned this Feb 5, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 5, 2024 17:04
Copy link
Contributor

github-actions bot commented Feb 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen requested a review from a team as a code owner February 5, 2024 17:12
Copy link

sonarcloud bot commented Feb 5, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3b9df37) 40.75% compared to head (f66c24c) 40.75%.

Files Patch % Lines
...foundation/BottomSheetDialog/BottomSheetDialog.tsx 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8526      +/-   ##
==========================================
- Coverage   40.75%   40.75%   -0.01%     
==========================================
  Files        1242     1242              
  Lines       30052    30055       +3     
  Branches     2876     2878       +2     
==========================================
+ Hits        12249    12250       +1     
  Misses      17102    17102              
- Partials      701      703       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Checked code
  • Did not check local build

@brianacnguyen brianacnguyen merged commit 9f2f5f5 into main Feb 6, 2024
26 checks passed
@brianacnguyen brianacnguyen deleted the fix/bottomsheet-keyboard-avoiding-view branch February 6, 2024 01:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 6, 2024
@metamaskbot metamaskbot added release-7.17.0 Issue or pull request that will be included in release 7.17.0 release-7.16.0 Issue or pull request that will be included in release 7.16.0 and removed release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 6, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0.

@chrisleewilcox chrisleewilcox added release-7.17.0 Issue or pull request that will be included in release 7.17.0 and removed release-7.16.0 Issue or pull request that will be included in release 7.16.0 labels Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: User is unable to view the text dialog to enable the option for ETH_SIGN
5 participants