Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added inherited to build settings library search paths #8536

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Feb 6, 2024

Description

Currently when running simulator, this issue arises
Screenshot 2024-02-05 at 7 16 56 PM

Per @vivek-consensys 's suggestion, this PR adds ${inherited} to the Library Search Paths
image

Related issues

Fixes: N/A

Manual testing steps

  1. Start the ios simulator

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Feb 6, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 6, 2024 21:23
Copy link
Contributor

github-actions bot commented Feb 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen self-assigned this Feb 6, 2024
@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 6, 2024
@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 6, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fd60d9) 40.80% compared to head (797adea) 40.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8536   +/-   ##
=======================================
  Coverage   40.80%   40.80%           
=======================================
  Files        1245     1245           
  Lines       30119    30119           
  Branches     2889     2889           
=======================================
  Hits        12289    12289           
  Misses      17127    17127           
  Partials      703      703           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6a15efbb-007a-418b-9edb-e93106900592
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@Cal-L Cal-L added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Feb 6, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L Cal-L merged commit b0fbb66 into main Feb 7, 2024
31 checks passed
@Cal-L Cal-L deleted the fix/gradient branch February 7, 2024 00:35
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants