-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: blockaid banner UX improvements #8544
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6848c6f4-f805-4c9e-a9d5-deb3fee976f0 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8544 +/- ##
==========================================
+ Coverage 40.80% 40.90% +0.10%
==========================================
Files 1245 1245
Lines 30119 30148 +29
Branches 2889 2894 +5
==========================================
+ Hits 12289 12333 +44
+ Misses 17127 17112 -15
Partials 703 703 ☔ View full report in Codecov by Sentry. |
|
Description
Changes in blockaid banner UX to make it more intuitive for users.
Related issues
Fixes: MetaMask/MetaMask-planning#2038
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-02-07.at.2.18.19.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist