-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert slice engine #8587
fix: revert slice engine #8587
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c6b9190-c2d6-459c-a97b-b451eea74f15 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8587 +/- ##
==========================================
- Coverage 41.12% 41.08% -0.05%
==========================================
Files 1246 1245 -1
Lines 30314 30330 +16
Branches 2960 2962 +2
==========================================
- Hits 12468 12462 -6
- Misses 17103 17125 +22
Partials 743 743 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Revert of #8081
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist