Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert slice engine #8587

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: revert slice engine #8587

merged 1 commit into from
Feb 15, 2024

Conversation

tommasini
Copy link
Contributor

Description

Revert of #8081

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner February 14, 2024 23:21
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title revert slice engine fix: revert slice engine Feb 14, 2024
@tommasini tommasini added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 14, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c6b9190-c2d6-459c-a97b-b451eea74f15
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (7956445) 41.12% compared to head (05528f7) 41.08%.

Files Patch % Lines
app/store/persistConfig.ts 12.00% 22 Missing ⚠️
app/components/UI/DrawerView/index.js 0.00% 10 Missing ⚠️
app/core/redux/slices/engine/index.ts 92.30% 0 Missing and 1 partial ⚠️
app/reducers/navigation/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8587      +/-   ##
==========================================
- Coverage   41.12%   41.08%   -0.05%     
==========================================
  Files        1246     1245       -1     
  Lines       30314    30330      +16     
  Branches     2960     2962       +2     
==========================================
- Hits        12468    12462       -6     
- Misses      17103    17125      +22     
  Partials      743      743              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 14, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 8ec9970 into main Feb 15, 2024
31 of 32 checks passed
@tommasini tommasini deleted the fix/revert-slice-engine branch February 15, 2024 00:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants