Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-structure confirmation pages #8588

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

segun
Copy link
Contributor

@segun segun commented Feb 15, 2024

Description

Currently, each team works on/owns dozens of different folders and files within our multiple repos, making it harder to:
Define code owners
Get metrics by teams

For proposed solution see this document

Related issues

Fixes: #1952

Screen Recording

recording_levels.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun requested a review from a team as a code owner February 15, 2024 08:47
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd698b6) 41.09% compared to head (66ef5e3) 41.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8588      +/-   ##
==========================================
- Coverage   41.09%   41.06%   -0.03%     
==========================================
  Files        1245     1246       +1     
  Lines       30332    30320      -12     
  Branches     2962     2962              
==========================================
- Hits        12464    12452      -12     
  Misses      17125    17125              
  Partials      743      743              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segun segun self-assigned this Feb 15, 2024
@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 15, 2024
Move send and send flow to confirmations

Re-org confirmation group pages.

Fix tests and lint

Move hooks too

remove podfile changes

de-deplicate gas price settings.
@segun segun force-pushed the olu/refactor-confirmation-pages branch from 4f32ea7 to 66ef5e3 Compare February 15, 2024 09:21
Copy link

sonarcloud bot commented Feb 15, 2024

@segun segun merged commit 912d6c8 into main Feb 15, 2024
26 checks passed
@segun segun deleted the olu/refactor-confirmation-pages branch February 15, 2024 13:52
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants