-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nft detection running too many times #8603
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8603 +/- ##
=======================================
Coverage 41.06% 41.06%
=======================================
Files 1247 1247
Lines 30351 30351
Branches 2963 2963
=======================================
Hits 12464 12464
Misses 17142 17142
Partials 745 745 ☔ View full report in Codecov by Sentry. |
|
Still needed, will do after #9110 |
…/nft-detection-controller-too-many-calls
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Tested using Flipper network log. OS request only happen when switching this specific setting on.
|
Description
Porting this core PR to mobile.
Related issues
Fixes an issue where the NFT detection controller was running too many times. It would send an HTTP request to fetch NFTs when any setting changed. It should only do so when the autodetect NFT setting changes.
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-02-15.at.10.22.54.PM.mov
After
Pre-merge author checklist
Pre-merge reviewer checklist