Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ppom_release to fix fail ppom security validation check #8605

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

cryptotavares
Copy link
Contributor

Description

A recent geth update and how a eth_createAccessList request is handled when passed certain variables, created an incompatibility with ppom causing it to fail with gasPrice must be non-zero after london fork, data: None).

The incompatibility of ppom and the latest changes in geth is handled in v1.4.1 of ppom_release.

Related issues

Fixes: #8589

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Updating ppom fixes an ongoing issue
caused by an updated of geth in the infura
nodes
@cryptotavares cryptotavares requested a review from a team as a code owner February 16, 2024 11:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptotavares cryptotavares changed the title fix: update ppom fix: Update ppom_release to fix fail ppom security validation check Feb 16, 2024
@seaona seaona added team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 16, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9b928279-78df-427f-8a8c-af7fd8dcfda2
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23dc52b) 41.06% compared to head (7753432) 41.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8605   +/-   ##
=======================================
  Coverage   41.06%   41.06%           
=======================================
  Files        1247     1247           
  Lines       30351    30351           
  Branches     2963     2963           
=======================================
  Hits        12464    12464           
  Misses      17142    17142           
  Partials      745      745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cryptotavares cryptotavares merged commit 215a969 into main Feb 16, 2024
34 of 35 checks passed
@cryptotavares cryptotavares deleted the fix-ppom-infura-security-issue branch February 16, 2024 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
@metamaskbot metamaskbot added release-7.17.0 Issue or pull request that will be included in release 7.17.0 release-7.16.0 Issue or pull request that will be included in release 7.16.0 and removed release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 16, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0.

@chrisleewilcox chrisleewilcox added release-7.17.0 Issue or pull request that will be included in release 7.17.0 and removed release-7.16.0 Issue or pull request that will be included in release 7.16.0 labels Feb 16, 2024
@chrisleewilcox
Copy link
Contributor

cherry-pick PR into release: #8609

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
6 participants