-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Signature controller update to v5.3.0 and removed unnecessary patch #8608
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/message-manager@7.3.7, npm/@metamask/signature-controller@4.0.1, npm/@metamask/utils@8.2.1 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Quality Gate passedIssues Measures |
For the eth_sign button, you have to unfocus the input field before the button can be enabled |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a8a7c4d-c83b-4ba8-8fce-368832aed53b |
Eth_sign confirmed:https://recordit.co/f3SS2lzGLL |
Description
Update Signature controller to verison 5.3.0
Removed unnecessary patch
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
http://recordit.co/sjLxpGp2Of
eth_sign
https://recordit.co/f3SS2lzGLL
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist