Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Signature controller update to v5.3.0 and removed unnecessary patch #8608

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Feb 16, 2024

Description

Update Signature controller to verison 5.3.0
Removed unnecessary patch

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

http://recordit.co/sjLxpGp2Of

eth_sign
https://recordit.co/f3SS2lzGLL

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Feb 16, 2024
@tommasini tommasini requested a review from a team as a code owner February 16, 2024 16:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Feb 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/message-manager@7.3.8 Transitive: environment, filesystem, network +76 12.5 MB metamaskbot
npm/@metamask/signature-controller@5.3.0 Transitive: environment, filesystem, network +90 16.5 MB metamaskbot

🚮 Removed packages: npm/@metamask/message-manager@7.3.7, npm/@metamask/signature-controller@4.0.1, npm/@metamask/utils@8.2.1

View full report↗︎

Copy link

socket-security bot commented Feb 16, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L
Copy link
Contributor

Cal-L commented Feb 16, 2024

For the eth_sign button, you have to unfocus the input field before the button can be enabled

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 16, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a8a7c4d-c83b-4ba8-8fce-368832aed53b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@tommasini
Copy link
Contributor Author

tommasini commented Feb 16, 2024

Eth_sign confirmed:https://recordit.co/f3SS2lzGLL
will paste on the description!

@tommasini tommasini merged commit 6788c2e into main Feb 19, 2024
30 checks passed
@tommasini tommasini deleted the feat/1537-signature-controller-v5.3.0 branch February 19, 2024 10:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 19, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants