test: Refactor settings page object

[cortisiko]

Description

The purpose of this PR is to continue on with our work to refactor page objects in our e2e test code.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

Smoke on main: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53f88ce9-0360-494e-84aa-4c9798983ad7
Regression on main: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27b6e69b-1f15-40be-b5a4-2d4f07f6ac82

After

Smoke: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/39c38a2b-cdfd-4993-bdf3-14b3de741386
Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d3903f4e-7f87-48d1-97cd-5eba0fb404d1

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48b1f97) 41.43% compared to head (d29b358) 41.43%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8644   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files        1254     1254           
  Lines       30565    30565           
  Branches     3001     3001           
=======================================
  Hits        12666    12666           
  Misses      17146    17146           
  Partials      753      753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cal-L]

LGTM

[MarioAslau]

Looks good!

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud