-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tabs and swaps components events migration #8651
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Quality Gate passedIssues Measures |
Description
tabs and swaps components under UI folder, with new Segment metrics.
Snapshot updated on Tabs, needs to migrate to react-testing-library
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
https://recordit.co/w5SwTPfpHj
https://recordit.co/n7sVQDCkCL
** Not all the events were recorded **
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist