-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migration of analytics of NavBar, NavBarTitle, LedgerConfirmationModal #8655
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8655 +/- ##
=======================================
Coverage 41.43% 41.44%
=======================================
Files 1254 1254
Lines 30565 30562 -3
Branches 3001 3001
=======================================
Hits 12666 12666
+ Misses 17146 17143 -3
Partials 753 753 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
NavBar, NavBarTitle, LedgerConfirmationModal components under UI folder, with new Segment metrics.
Updated snapshot
Was not able to confirm analytics on navbar of quotes view or Ledger (do not have a ledger)
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Navbar: https://recordit.co/4SpXor69Ov
NavbarTitle: https://recordit.co/zdjoHcoox5
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist