-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Edit gas, Drawer, DeleteWallet, ComponentErrorBoundary, CollectilbleContracts, BrowsserBottomBar events migration #8656
Conversation
…ontracts, BrowserBottomBar events migration
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the unit test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8656 +/- ##
==========================================
- Coverage 41.46% 41.43% -0.03%
==========================================
Files 1263 1263
Lines 30610 30611 +1
Branches 3008 3008
==========================================
- Hits 12693 12685 -8
- Misses 17164 17173 +9
Partials 753 753 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending Sonarcloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Quality Gate passedIssues Measures |
Description
Edit gas, Drawer, DeleteWallet, ComponentErrorBoundary, CollectilbleContracts, BrowsserBottomBar components under UI folder, with new Segment metrics.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
EditGasFee1559: https://recordit.co/anjzzwWcSa
EditGasFeeLegacy: https://recordit.co/slAa7Fpgza
CollectibleContracts: https://recordit.co/QFiCkWzVGX
BrowserBottomBar: https://recordit.co/ciQb4P51Fg
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist