Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update Swap token from USDC to USDT #8662

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

cortisiko
Copy link
Member

Description

The E2E swaps smoke tests started failing because swapping from ETH<> USDC resulted in a failed swap txn. Changing the stablecoin to USDT resulted in a successful txn. I have manually tested this and was unable to reproduce it.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-platform labels Feb 21, 2024
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e26750a) 41.43% compared to head (cda2757) 41.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8662   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files        1254     1254           
  Lines       30565    30565           
  Branches     3001     3001           
=======================================
  Hits        12666    12666           
  Misses      17146    17146           
  Partials      753      753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortisiko cortisiko marked this pull request as ready for review February 21, 2024 22:46
@cortisiko cortisiko requested a review from a team as a code owner February 21, 2024 22:46
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 21, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d4ef6a2-605b-4503-9c15-bb511919c787
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@cortisiko
Copy link
Member Author

Moments after opening this PR, swapping from ETH<>USDC started working again. There must have been a hiccup on Tenderly's end. Closing PR.

@cortisiko cortisiko closed this Feb 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
@cortisiko cortisiko reopened this Feb 28, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit 0d875fb into main Feb 28, 2024
28 checks passed
@cortisiko cortisiko deleted the detox/update-swap-token branch February 28, 2024 22:40
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants