-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update Swap token from USDC to USDT #8662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8662 +/- ##
=======================================
Coverage 41.43% 41.43%
=======================================
Files 1254 1254
Lines 30565 30565
Branches 3001 3001
=======================================
Hits 12666 12666
Misses 17146 17146
Partials 753 753 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d4ef6a2-605b-4503-9c15-bb511919c787 |
Moments after opening this PR, swapping from ETH<>USDC started working again. There must have been a hiccup on Tenderly's end. Closing PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The E2E swaps smoke tests started failing because swapping from ETH<> USDC resulted in a failed swap txn. Changing the stablecoin to USDT resulted in a successful txn. I have manually tested this and was unable to reproduce it.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist