refactor: consolidate accounts references to a single source of truth

[owencraston]

Description

1. What is the reason for the change?
   The accounts team is working towards the integration of the new accounts controller. This controller will become the source of truth for all things accounts (name address, methods KeyringType etc). In order to make this integration easier we must first centralize the source of truth for accounts.
2. What is the improvement/solution?

• Currently account information is being derived from the preferences controller. In this PR I removed direct use of state.engine.backgroundState.PreferencesController in favour of the respective redux selectors. I also migrated the Wallet screen to use the useAccounts hook which achieves the same result as before but without custom logic.

There should be no visible or functional changes to the app.

Related issues

Fixes: #8482

Notes for code reviewers

• 🔴 No use of backgroundState.PreferencesController selectedAddress and identities
• 🟢 Instead they should all be using the selectIdentities and the selectSelectedAddress selectors

Manual testing steps

There should be no visible changes after this PR

1. create/import a wallet
2. click the 3 dots on the the account selector
3. change the account name
4. add an account
5. open the browser
6. navigate to a dapp: https://uniswap.org/
7. connect the dapp
8. ensure that the account names are the same as the ones you input previously

Screenshots/Recordings

Before

After

Creation flow

Screen.Recording.2024-02-26.at.7.01.50.PM.mov

Import flow

Screen.Recording.2024-02-26.at.7.15.26.PM.mov

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[M111111111r]

Mahdi

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 41.37%. Comparing base (4411edc) to head (23b13d3).

Files	Patch %	Lines
app/components/Views/Wallet/index.tsx	50.00%	2 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8664      +/-   ##
==========================================
- Coverage   41.38%   41.37%   -0.01%     
==========================================
  Files        1266     1266              
  Lines       30769    30768       -1     
  Branches     3028     3031       +3     
==========================================
- Hits        12734    12731       -3     
- Misses      17275    17276       +1     
- Partials      760      761       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ae949224-4ee9-45fc-a686-29446f28ccad
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[tommasini]

Very cool logic abstraction, it will indeed bring value, just left a question

[tommasini]

LGTM!

[gantunesr]

lgtm, just left a couple of extreme nitpicks

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/810408dd-838f-4dba-81ab-e8fc00bd745b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
73.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud