Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TagColored to component temp #8677

Merged
merged 3 commits into from
Feb 22, 2024
Merged

feat: Add TagColored to component temp #8677

merged 3 commits into from
Feb 22, 2024

Conversation

brianacnguyen
Copy link
Contributor

Description

Related issues

Fixes: #8676

Manual testing steps

  1. Change pointer in index.js to Storybook to open Storybook
  2. Click on Components Temp
  3. Click on TagColored

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-22.at.08.48.39.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Feb 22, 2024
@brianacnguyen brianacnguyen self-assigned this Feb 22, 2024
@brianacnguyen brianacnguyen requested review from a team as code owners February 22, 2024 16:53
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei
Copy link
Member

LGTM!

wachunei
wachunei previously approved these changes Feb 22, 2024
Copy link

sonarcloud bot commented Feb 22, 2024

Copy link

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My mobile repo isn't running locally but I saw Pedro's screenshot and it looks good.

.storybook/main.js Show resolved Hide resolved
@brianacnguyen brianacnguyen merged commit 291bc71 into main Feb 22, 2024
28 checks passed
@brianacnguyen brianacnguyen deleted the tag-colored branch February 22, 2024 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 22, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-design-system All issues relating to design system in Mobile
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add TagColored to component-temp
4 participants