-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix metrics trackEvent compatibility with legacy events #8678
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8678 +/- ##
==========================================
+ Coverage 41.48% 41.53% +0.04%
==========================================
Files 1256 1260 +4
Lines 30581 30615 +34
Branches 3002 3005 +3
==========================================
+ Hits 12687 12716 +29
- Misses 17141 17145 +4
- Partials 753 754 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
Description
Add handling of legacy events that have properties inside the event
Related issues
Realted to https://github.com/MetaMask/mobile-planning/issues/1129
Manual testing steps
NA - see unit tests
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist