Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: confirmations views components events migration #8712

Merged
merged 8 commits into from
Feb 26, 2024

Conversation

tommasini
Copy link
Contributor

Description

Confirmations folder junder Views folder events migration

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Feb 24, 2024
@tommasini tommasini requested a review from a team as a code owner February 24, 2024 00:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly suggestions to destructure metrics from props when relevant

NicolasMassart
NicolasMassart previously approved these changes Feb 26, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

sonarcloud bot commented Feb 26, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.07792% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 41.48%. Comparing base (baed762) to head (cb33781).

Files Patch % Lines
...s/Views/confirmations/ApproveView/Approve/index.js 0.00% 12 Missing ⚠️
...p/components/Views/confirmations/Approval/index.js 0.00% 9 Missing ⚠️
...tions/components/ApproveTransactionReview/index.js 0.00% 9 Missing ⚠️
...ents/Views/confirmations/SendFlow/Confirm/index.js 14.28% 6 Missing ⚠️
app/components/Views/confirmations/Send/index.js 0.00% 5 Missing ⚠️
...nents/Views/confirmations/SendFlow/SendTo/index.js 0.00% 3 Missing ⚠️
...nts/ApproveTransactionReview/AddNickname/index.tsx 0.00% 3 Missing ⚠️
...nents/Views/confirmations/SendFlow/Amount/index.js 33.33% 2 Missing ⚠️
...rmations/components/EditGasFee1559Update/index.tsx 33.33% 2 Missing ⚠️
...onfirmations/components/TransactionReview/index.js 60.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8712      +/-   ##
==========================================
+ Coverage   41.46%   41.48%   +0.01%     
==========================================
  Files        1263     1263              
  Lines       30610    30609       -1     
  Branches     3008     3008              
==========================================
+ Hits        12693    12698       +5     
+ Misses      17164    17158       -6     
  Partials      753      753              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 26, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5713e623-46f3-4a56-982b-8555dd6b8b9f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@NicolasMassart NicolasMassart merged commit 0e2c734 into main Feb 26, 2024
30 checks passed
@NicolasMassart NicolasMassart deleted the feat/batch_1129_segment_15 branch February 26, 2024 16:42
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants