Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Onboarding add custom default ETH Mainnet #8723

Merged
merged 31 commits into from
Mar 8, 2024

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Feb 26, 2024

Description

New test for adding a custom default ETH Mainnet during Onboarding after MMM has been installed on device.
Added this test as part of the Regression tests.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1455

Manual testing steps

On local machine run on this branch...
Android: yarn test:e2e:android:debug:single ./e2e/specs/onboarding/add-custom-eth-mainnet.spec.js
iOS: yarn test:e2e:ios:debug:single ./e2e/specs/onboarding/add-custom-eth-mainnet.spec.js

On bitrise run pr_regression_e2e_pipeline on this branch.

Above steps should pass.

Screenshots/Recordings

Before

After

Regression tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27207577-3107-4fdb-b0b7-56561831c263
Smoke tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d64d3b0-8537-4c24-8b98-a832bfdd4211

Screen.Recording.2024-02-26.at.11.48.29.AM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Fix merge conflicts
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.23%. Comparing base (c02483c) to head (6bfb8eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8723   +/-   ##
=======================================
  Coverage   43.23%   43.23%           
=======================================
  Files        1271     1271           
  Lines       30905    30905           
  Branches     3088     3088           
=======================================
  Hits        13361    13361           
  Misses      16769    16769           
  Partials      775      775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisleewilcox chrisleewilcox changed the title test: onboarding add custom default ETH Mainnet test: Onboarding add custom default ETH Mainnet Feb 26, 2024
@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Feb 26, 2024
@chrisleewilcox chrisleewilcox marked this pull request as ready for review February 26, 2024 20:21
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner February 26, 2024 20:21
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 26, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7232eb05-77eb-4bc1-84ab-733f93f651bd
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@chrisleewilcox chrisleewilcox removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 2, 2024
@chrisleewilcox chrisleewilcox added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 2, 2024
Copy link
Contributor

github-actions bot commented Mar 2, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 521ad1d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/42b56e64-fa39-46a7-949a-805fd201936f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@chrisleewilcox chrisleewilcox added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5ce5cc7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9f3354e8-2c93-4ae8-ba3c-eac6d45e050f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Mar 6, 2024
@chrisleewilcox chrisleewilcox removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 7, 2024
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@chrisleewilcox chrisleewilcox merged commit 9103133 into main Mar 8, 2024
29 checks passed
@chrisleewilcox chrisleewilcox deleted the test/onboarding-add-custom-eth-mainnet branch March 8, 2024 00:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 8, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants