Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change in blockaid alert message #8725

Merged
merged 4 commits into from
Feb 28, 2024
Merged

fix: change in blockaid alert message #8725

merged 4 commits into from
Feb 28, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 26, 2024

Description

Change in blockaid alert message.

Related issues

Fixes: #2145

Manual testing steps

  1. Enable blockaid and open test dapp
  2. Submit a benign transaction
  3. Check message after validation completes.

Screenshots/Recordings

Screenshot 2024-02-27 at 2 43 19 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Feb 26, 2024
@jpuri jpuri requested a review from a team as a code owner February 26, 2024 08:14
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Change in blockaid alert message fix: change in blockaid alert message Feb 26, 2024
blackdevelopa
blackdevelopa previously approved these changes Feb 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.38%. Comparing base (01c6724) to head (f5df43a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8725   +/-   ##
=======================================
  Coverage   41.38%   41.38%           
=======================================
  Files        1266     1266           
  Lines       30768    30768           
  Branches     3028     3028           
=======================================
  Hits        12733    12733           
  Misses      17275    17275           
  Partials      760      760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 26, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f9720aab-c9bc-4382-b532-f294f003cd8b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

segun
segun previously approved these changes Feb 26, 2024
digiwand
digiwand previously approved these changes Feb 26, 2024
@jpuri jpuri dismissed stale reviews from digiwand, segun, and blackdevelopa via 5199843 February 27, 2024 09:13
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jpuri jpuri merged commit 7f214af into main Feb 28, 2024
28 checks passed
@jpuri jpuri deleted the change_blockaid_alert_msg branch February 28, 2024 00:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2024
@metamaskbot metamaskbot added release-7.18.0 Issue or pull request that will be included in release 7.18.0 release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 28, 2024
@metamaskbot metamaskbot removed the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.17.0 on PR. Adding release label release-7.17.0 on PR and removing other release labels(release-7.18.0), as PR was cherry-picked in branch 7.17.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants