Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): add event when user expands quotes #8729

Merged
merged 19 commits into from
Mar 1, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Feb 26, 2024

Note

This PR is based on #8680

Description

This PR adds an event when the user expands the quotes to explore more options in the simplified view

Related issues

https://consensyssoftware.atlassian.net/browse/ONRAMP-1407

Manual testing steps

  1. Go through a buy or sell flow
  2. After receiving quotes, tapping on the Explore more options link if available must trigger a new event.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Feb 26, 2024
@wachunei wachunei force-pushed the feat/ramp-explore-quotes-event branch from e286905 to 9971337 Compare February 26, 2024 15:43
@wachunei wachunei changed the title feat(ramp): add bottom sheet quotes feat(ramp): add event when user expands quotes Feb 26, 2024
@wachunei
Copy link
Member Author

Leaving this as a draft until the event properties are reviewed. Can you please take a look @lorenzosantos?

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 41.47%. Comparing base (0b2d069) to head (2b28c12).
Report is 16 commits behind head on feat/ramp-previously-used-provider.

Files Patch % Lines
app/components/UI/Ramp/Views/Quotes/Quotes.tsx 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           feat/ramp-previously-used-provider    #8729      +/-   ##
======================================================================
- Coverage                               41.53%   41.47%   -0.06%     
======================================================================
  Files                                    1260     1263       +3     
  Lines                                   30677    30679       +2     
  Branches                                 3024     3028       +4     
======================================================================
- Hits                                    12741    12724      -17     
- Misses                                  17175    17193      +18     
- Partials                                  761      762       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei force-pushed the feat/ramp-explore-quotes-event branch from 9971337 to b0dca32 Compare February 28, 2024 02:51
@wachunei wachunei changed the base branch from feat/ramp-bottom-sheet-quotes to feat/ramp-previously-used-provider February 28, 2024 02:51
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei force-pushed the feat/ramp-explore-quotes-event branch from b0dca32 to 7bffd2e Compare February 28, 2024 02:55
@wachunei wachunei force-pushed the feat/ramp-explore-quotes-event branch from 7bffd2e to 2b28c12 Compare February 28, 2024 02:56
@wachunei wachunei marked this pull request as ready for review February 28, 2024 02:57
@wachunei wachunei requested a review from a team as a code owner February 28, 2024 02:57
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 28, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/305a07c0-53f6-41d3-89a5-de304dc71df0
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Cal-L
Cal-L previously approved these changes Feb 28, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2024
Base automatically changed from feat/ramp-previously-used-provider to main February 29, 2024 13:37
@wachunei wachunei dismissed Cal-L’s stale review February 29, 2024 13:37

The base branch was changed.

@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 29, 2024
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 29, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 67e3d80
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3063c6f6-8b78-4fc4-a9af-9165a960d32a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bkirb
Copy link
Contributor

bkirb commented Feb 29, 2024

LGTM, I verified the event appeared in logs with Pedro ✅

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Mar 1, 2024
@wachunei
Copy link
Member Author

wachunei commented Mar 1, 2024

@Cal-L can you please re-review, this has just changed the base branch 🙏

Copy link

sonarcloud bot commented Mar 1, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 1, 2024
@wachunei wachunei merged commit 92c17e9 into main Mar 1, 2024
31 checks passed
@wachunei wachunei deleted the feat/ramp-explore-quotes-event branch March 1, 2024 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants