Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Missing migration events #8731

Merged
merged 4 commits into from
Feb 27, 2024
Merged

feat: Missing migration events #8731

merged 4 commits into from
Feb 27, 2024

Conversation

tommasini
Copy link
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini marked this pull request as ready for review February 26, 2024 18:23
@tommasini tommasini requested review from a team as code owners February 26, 2024 18:23
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 26, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cac46bec-0014-479c-9cba-b109b15002c3
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 41.42%. Comparing base (4869690) to head (5fbf181).

Files Patch % Lines
...Settings/NetworksSettings/NetworkSettings/index.js 0.00% 2 Missing ⚠️
app/core/RPCMethods/wallet_addEthereumChain.js 60.00% 2 Missing ⚠️
...omponents/UI/AccountApproval/showWarningBanner.tsx 0.00% 1 Missing ⚠️
...uritySettings/Sections/AutomaticSecurityChecks.tsx 50.00% 1 Missing ⚠️
...ngs/SecuritySettings/Sections/BlockaidSettings.tsx 50.00% 1 Missing ⚠️
...s/Sections/ProtectYourWallet/ProtectYourWallet.tsx 50.00% 1 Missing ⚠️
...ngs/Sections/RevealPrivateKey/RevealPrivateKey.tsx 50.00% 1 Missing ⚠️
app/core/Engine.ts 0.00% 1 Missing ⚠️
app/core/RPCMethods/wallet_switchEthereumChain.js 0.00% 1 Missing ⚠️
app/core/SecureKeychain.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8731      +/-   ##
==========================================
- Coverage   41.46%   41.42%   -0.04%     
==========================================
  Files        1264     1264              
  Lines       30622    30626       +4     
  Branches     3008     3008              
==========================================
- Hits        12697    12688       -9     
- Misses      17172    17185      +13     
  Partials      753      753              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 26, 2024
NicolasMassart
NicolasMassart previously approved these changes Feb 26, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@M111111111r

This comment was marked as spam.

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 26, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0cb2396-52ee-4ba1-9b3a-99bb2221e84f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Feb 27, 2024

@tommasini tommasini merged commit 07590a4 into main Feb 27, 2024
26 checks passed
@tommasini tommasini deleted the feat/batch_1129_segment_18 branch February 27, 2024 00:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 27, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants