Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update origin passed to ppom for send transactions #8742

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Feb 27, 2024

Description

Context: https://consensys.slack.com/archives/C05HZHDS89Z/p1708946195217929
Pass origin as metamask for ppom validate request

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@blackdevelopa blackdevelopa requested a review from a team as a code owner February 27, 2024 10:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Feb 27, 2024
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@blackdevelopa blackdevelopa self-assigned this Feb 27, 2024
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 27, 2024
@blackdevelopa blackdevelopa merged commit 6ddffcf into main Feb 27, 2024
36 of 37 checks passed
@blackdevelopa blackdevelopa deleted the 2148/change_origin_ppom branch February 27, 2024 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 27, 2024
@metamaskbot metamaskbot added release-7.18.0 Issue or pull request that will be included in release 7.18.0 release-7.17.0 Issue or pull request that will be included in release 7.17.0 and removed release-7.18.0 Issue or pull request that will be included in release 7.18.0 labels Feb 27, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.17.0 on PR. Adding release label release-7.17.0 on PR and removing other release labels(release-7.18.0), as PR was cherry-picked in branch 7.17.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants