Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed underline issue with ButtonLink's pressed state #8752

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Currently when the ButtonLink is pressed, the underline style is added but it also affected the Button's alignment. This PR fixes that issue

Related issues

Fixes: #8596

Manual testing steps

  1. Go to any page with a ButtonLink
  2. Press on it

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-26.at.20.31.52.mp4

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-26.at.20.32.11.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Feb 27, 2024
@brianacnguyen brianacnguyen self-assigned this Feb 27, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 27, 2024 17:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.43%. Comparing base (5fe71b8) to head (8a81c20).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8752   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files        1270     1270           
  Lines       30833    30833           
  Branches     3043     3043           
=======================================
  Hits        12775    12775           
  Misses      17295    17295           
  Partials      763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wachunei
wachunei previously approved these changes Feb 27, 2024
@wachunei wachunei mentioned this pull request Feb 27, 2024
13 tasks
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit b536b96 into main Feb 27, 2024
28 checks passed
@brianacnguyen brianacnguyen deleted the fix/buttonlink-bs branch February 27, 2024 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 27, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: the pressedIn state for the link also overrides the spacing in BottomSheetFooter
5 participants