fix: Updated accessibility role for buttons

[brianacnguyen]

Description

• Updated accessibility role for buttons and text inside buttons
• Enabled 'Text' to accept accessibilityRole

Related issues

Fixes: #8630

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[wachunei]

I just want to note that the main issue described in #8630 is not fixed by this. The main issue is the button component to not have { accessibilityRole: "button", accessible: true } as props.

[brianacnguyen]

I just want to note that the main issue described in #8630 is not fixed by this. The main issue is the button component to not have { accessibilityRole: "button", accessible: true } as props.

Updated

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.43%. Comparing base (b536b96) to head (284d615).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8753   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files        1270     1270           
  Lines       30833    30833           
  Branches     3043     3043           
=======================================
  Hits        12775    12775           
  Misses      17295    17295           
  Partials      763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud