Fix add to addressbook #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brunobar79
commented
Jul 19, 2019
brunobar79
commented
- No need to store addresses on dapp proposed transactions
- decode tx data for non ETH transactions and extract the receiver to add to the addressbook
…-mobile into fix-add-to-addressbook
brunobar79
added
the
needs-qa
ibrahimtaveras00
approved these changes
Jul 19, 2019
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* dont save on approval screen * decode data for non eth txs and extract to * try and catch * fix proptype * fix proptype * add collectibles support * more fixes * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.