fix: normalize transaction parameters before PPOM validation

[matthewwalsh0]

Description

Update the TransactionController to pad the data property to an even length to ensure the client UIs receive a consistent data value.

Normalize transaction parameters before validating with the PPOM to ensure the data can be parsed correctly, and all parameters are in a consistent format.

See the core branch diff for a clearer view of the patch changes.

Related issues

Fixes: #2152 #2153

Manual testing steps

1. Update test dApp locally to remove leading zero in malicious approval data.
2. Verify associated button still displays approval confirmation.
3. Verify associated button still displays deceptive request warning.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 49e5309
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cc6e29d9-6072-4423-a553-a1d6ba60c615

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[seaona]

This looks good from QA:

• 🟢 hex data is normalized
• 🟢 ppom validation works with odd hex data, since it's normalized (ie approve without a 0)
• Send flow with Edit hex data cannot be initiated from inside the wallet - so no change here

I've triggered a Bitrise e2e build here: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/961e97dd-afd4-4ed1-962f-6487f418d0f0

odd-hex-data-mobile.mp4

[dbrans]

Fantastic work, @matthewwalsh0!