Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Assets controllers update to version 10 #8778

Merged
merged 10 commits into from
Mar 6, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Feb 29, 2024

Description

Update assets controllers to version 10

Added script to make easier update the next versions of assets-controllers

Core branch with changes: patch/mobile-assets-controllers-v10 : https://github.com/MetaMask/core/tree/patch/mobile-assets-controllers-v10

Still missing recordings of exploratory testing

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Token exploration: https://recordit.co/jiLNME568H
NFT exploration: https://recordit.co/QtOD9Gw1Va
Add token via dapp: https://recordit.co/t22cGKhdmG

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner February 29, 2024 00:02
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Feb 29, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Feb 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.63%. Comparing base (f743ea0) to head (eb5b7bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8778   +/-   ##
=======================================
  Coverage   41.63%   41.63%           
=======================================
  Files        1270     1270           
  Lines       30887    30887           
  Branches     3083     3083           
=======================================
+ Hits        12859    12860    +1     
+ Misses      17250    17249    -1     
  Partials      778      778           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 29, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8dc40f0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d848c703-6c1e-4dc5-b267-67e78b2f6c00

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 29, 2024
Copy link

socket-security bot commented Mar 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@10.0.0 Transitive: environment, filesystem, network +142 33.4 MB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@9.2.0, npm/zxcvbn@4.4.2

View full report↗︎

@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f61980e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e341b8b-8a55-480c-a7a9-d57dec5c71bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L previously approved these changes Mar 6, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/patch-assets-controllers.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: eb5b7bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8ab2bf3-1aca-4e45-9e18-21892dfc0769

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Mar 6, 2024

@tommasini tommasini merged commit f636a78 into main Mar 6, 2024
31 of 34 checks passed
@tommasini tommasini deleted the feat/1564-assets-controllers-v10 branch March 6, 2024 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 6, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants