Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: permissions system within sdk redux store #8785

Merged
merged 11 commits into from
Mar 6, 2024
Merged

feat: permissions system within sdk redux store #8785

merged 11 commits into from
Mar 6, 2024

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Feb 29, 2024 •
edited
Loading

Description

  • Migrate away from Default Preferences to manage persisted session state.
  • Migrate walletconnect to permission system
  • Connection flow optimization for ios mobile

Grouped within a single PR as these features are tightly integrated together.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team WalletConnect WalletConnect related issue or bug labels Mar 4, 2024
@abretonc7s abretonc7s marked this pull request as ready for review March 4, 2024 11:43
@abretonc7s abretonc7s requested a review from a team as a code owner March 4, 2024 11:43
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e7234e8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/afbd6544-890c-44e3-82a2-2e8dce366e77

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 49.64029% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 41.64%. Comparing base (0c45fbf) to head (f5e5e91).

Files Patch % Lines
...components/Views/AccountConnect/AccountConnect.tsx 0.00% 17 Missing ⚠️
app/core/WalletConnect/WalletConnectV2.ts 0.00% 13 Missing ⚠️
app/reducers/sdk/index.ts 50.00% 11 Missing and 1 partial ⚠️
app/actions/sdk/index.ts 72.00% 7 Missing ⚠️
...ts/Views/SDKSessionsManager/SDKSessionsManager.tsx 0.00% 5 Missing ⚠️
...e/SDKConnect/InitializationManagement/asyncInit.ts 68.75% 5 Missing ⚠️
app/core/RPCMethods/RPCMethodMiddleware.ts 50.00% 1 Missing and 2 partials ⚠️
...ventListenersHandlers/handleClientsDisconnected.ts 0.00% 2 Missing ⚠️
.../core/SDKConnect/ConnectionManagement/reconnect.ts 33.33% 2 Missing ⚠️
...SDKConnect/ConnectionManagement/watchConnection.ts 60.00% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8785      +/-   ##
==========================================
+ Coverage   41.61%   41.64%   +0.03%     
==========================================
  Files        1269     1271       +2     
  Lines       30871    30898      +27     
  Branches     3086     3083       -3     
==========================================
+ Hits        12846    12869      +23     
- Misses      17248    17252       +4     
  Partials      777      777

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andreahaku
andreahaku previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 self-assigned this Mar 5, 2024
@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 5, 2024
@christopherferreira9 christopherferreira9 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f5e5e91
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/476ec5c1-bda1-491b-bfe3-376e3e8924e9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

andreahaku
andreahaku previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andreahaku
andreahaku approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
46.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@christopherferreira9
Copy link
Contributor

LGTM

Test cases:

@christopherferreira9 christopherferreira9 merged commit 8299ec9 into main Mar 6, 2024
28 of 29 checks passed
@christopherferreira9 christopherferreira9 deleted the feat/more-permissions branch March 6, 2024 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
QA in Progress QA has started on the feature. release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-sdk SDK team WalletConnect WalletConnect related issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abretonc7s @codecov-commenter @christopherferreira9 @andreahaku @metamaskbot