-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove unnecessary resolutions #8803
Conversation
A number of resolutions were found to have zero impact upon the lockfile, i.e. they were completely ineffectual. They still pose a risk of breaking in the future as dependencies are added and updated, so these unnecessary resolutions have been removed.
5f5df67
to
f98f4f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8803 +/- ##
=======================================
Coverage 41.60% 41.60%
=======================================
Files 1269 1269
Lines 30859 30859
Branches 3082 3082
=======================================
Hits 12840 12840
Misses 17243 17243
Partials 776 776 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: e47db5f Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's give it 10 minutes to see the result of the E2E 🙏
Description
A number of resolutions were found to have zero impact upon the lockfile, i.e. they were completely ineffectual. They still pose a risk of breaking in the future as dependencies are added and updated, so these unnecessary resolutions have been removed.
Related issues
N/A
Manual testing steps
N/A, the
yarn.lock
file should suffice as evidence that this has no affect upon the application or tests or anything.Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist