chore: Remove minimatch resolution
#8807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8807 +/- ##
=======================================
Coverage 41.61% 41.61%
=======================================
Files 1269 1269
Lines 30869 30869
Branches 3086 3086
=======================================
Hits 12847 12847
Misses 17245 17245
Partials 777 777 ☔ View full report in Codecov by Sentry. |
Gudahtt
force-pushed
the
remove-minimatch-resolution
branch
from
2d00166
to
6c452c5
Compare
gauthierpetetin
added
the
needs-dev-review
|
Gudahtt
force-pushed
the
remove-minimatch-resolution
branch
from
6c452c5
to
0f7ab5d
Compare
|
Rebased to resolve conflicts |
This `minimatch` resolution was added in #5142 to address a security advisory. It is no longer needed, that advisory is not present after removing the resolution. This resolution was unsafe because it was forcing the use of incompatible versions of the package.
Gudahtt
force-pushed
the
remove-minimatch-resolution
branch
from
0f7ab5d
to
95a599c
Compare
|
Rebased to resolve conflicts |
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.19.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This
minimatchresolution was added in #5142 to address a security advisory. It is no longer needed, that advisory is not present after removing the resolution.This resolution was unsafe because it was forcing the use of incompatible versions of the package.
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist