feat: Network Controller to version 11.0.0 #8812
Conversation
…etwork Contrller updated to v11 and patch of network controller updated accordingly
tommasini
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again. Next stepsWhat is a deprecated package?The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed. Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution. What is a mild CVE?Contains a low severity Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. What is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. What's wrong with native code?Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs. Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings. What is a critical CVE?Contains a Critical Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. What is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. What is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
tommasini
added
Run Smoke E2E
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8812 +/- ##
==========================================
+ Coverage 41.63% 41.66% +0.02%
==========================================
Files 1270 1271 +1
Lines 30887 30906 +19
Branches 3083 3088 +5
==========================================
+ Hits 12860 12877 +17
- Misses 17249 17250 +1
- Partials 778 779 +1 ☔ View full report in Codecov by Sentry. |
… now ticker will always have ETH as default value
tommasini
added
Run Smoke E2E
|
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.19.0
Description
Migration to add ETH to ticker value if no ticker value is defined, Network Controller updated to v11 and patch of network controller updated accordingly
Removed fallback to 'ETH' from different place in the app since ticker will never be undefined from now on
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Exploratory testing: https://recordit.co/vOtYhl7Yau
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist