Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update Ledger connection instructions #8826

Merged
merged 9 commits into from
Mar 19, 2024

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Mar 4, 2024

Description

This PR has changed some instruction regarding how to connect to Ledger in en.json file.

Related issues

Fixes: #8714

Manual testing steps

  1. Import an SRP
  2. Follow the add hardware flow for Ledger devices
  3. Have Ledger device unlocked with the Ethereum app installed and bluetooth enabled
  4. Note that the connection instructions fail to tell the user to open the Ethereum app
  5. When the Ledger device is showing in the list of devices and the user taps Continue

Screenshots/Recordings

Before

image

After

IMG_0014

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dawnseeker8 dawnseeker8 requested a review from a team as a code owner March 4, 2024 09:33
Copy link
Contributor

github-actions bot commented Mar 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.26%. Comparing base (e63269f) to head (fd380f0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8826   +/-   ##
=======================================
  Coverage   43.26%   43.26%           
=======================================
  Files        1271     1271           
  Lines       30920    30920           
  Branches     3092     3092           
=======================================
  Hits        13379    13379           
  Misses      16769    16769           
  Partials      772      772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vivek-consensys
Copy link
Contributor

Tested locally using Samsung Android 13:
image

@dawnseeker8 dawnseeker8 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 556142f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4756216d-993e-4fe9-9900-3333873e7323

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0be54b3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/70f799a0-82c2-4ce1-96b2-bbb8b9a11f35

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dawnseeker8 dawnseeker8 added needs-content Needs content / copy support. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-content Needs content / copy support. Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c6ccdcf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/174e0f79-2e9d-4be8-aa37-4521bde8ab94

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr changed the title fix: Change the instruction content based on Corey Janssen's feedback refactor: update Ledger connection instructions Mar 19, 2024
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 19, 2024
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gantunesr gantunesr merged commit 872a958 into main Mar 19, 2024
32 of 34 checks passed
@gantunesr gantunesr deleted the fix/8714-ledger-instruction-change branch March 19, 2024 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-hardware-wallets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Connect Ledger- Looking for device incomplete instructions
5 participants