refactor: bring back IOS_SIMULATOR var as optional

[wachunei]

Description

This PR brings back the IOS_SIMULATOR variable for the yarn start:ios script, this time the variable will not have a default value.

This will allow users to specify a Simulator if they want. For example running this to select iPhone 15 Pro

IOS_SIMULATOR="iPhone 15 Pro" yarn start:ios

Related issues

Fixes:

Manual testing steps

1. Run IOS_SIMULATOR="iPhone 15 Pro" yarn start:ios, the build must succeed.
2. Change simulator to another one available and the build must succeed.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3169f15
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4c1750e2-44b7-4bdb-8dd7-99c5b6ffbad8

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud