chore: Remove plist resolution
#8835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/plist@3.0.5 |
Gudahtt
force-pushed
the
remove-plist-resolution
branch
from
c983f03
to
ee3a437
Compare
Gudahtt
added
needs-dev-review
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8835 +/- ##
=======================================
Coverage 41.61% 41.61%
=======================================
Files 1269 1269
Lines 30869 30869
Branches 3086 3086
=======================================
Hits 12847 12847
Misses 17245 17245
Partials 777 777 ☔ View full report in Codecov by Sentry. |
Gudahtt
force-pushed
the
remove-plist-resolution
branch
from
ee3a437
to
a13142d
Compare
The resolution for `plist` was added in #3987 to resolve a security advisory. At the time, the resolution was used to update the package, though a resolution wasn't needed to do this in the first place. Now that the package has been updated, this resolution is only having the effect of preventing further updates.
Gudahtt
force-pushed
the
remove-plist-resolution
branch
from
a13142d
to
8add793
Compare
|
NicolasMassart
approved these changes
Mar 5, 2024
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.19.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The resolution for
plistwas added in #3987 to resolve a security advisory. At the time, the resolution was used to update the package, though a resolution wasn't needed to do this in the first place. Now that the package has been updated, this resolution is only having the effect of preventing further updates.Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist