chore: Remove cross-fetch resolution

[Gudahtt]

Description

This resolution was added in #4249 to update the package in preparation for this package being updated in a controller update. That update happened long ago, and this resolution was not required to update the package in the first place. Today this just prevents the package from being updated.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/cross-fetch@3.1.8	network	+7	956 kB	lquixada

🚮 Removed packages: npm/cross-fetch@2.2.6

View full report↗︎

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: abe3e90
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd1d9450-a602-4c0a-a6ff-b8688bf3d964

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.61%. Comparing base (247d3ab) to head (abe3e90).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8836   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files        1269     1269           
  Lines       30869    30869           
  Branches     3086     3086           
=======================================
  Hits        12847    12847           
  Misses      17245    17245           
  Partials      777      777           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 52c6209
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9e31824b-9adf-498c-8617-c91544a5aaa4

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7cc668f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/417f9eeb-56aa-4955-9fda-b6027ba25c74

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[Gudahtt]

Two E2E failures, but both in different test suites. And neither failure seems related to this package at all (this dependency change only affects the SDK library). It worked the third time though. The failures must have been intermittent failures.

[Cal-L]

LGTM