ci: Create Bitrise status check for commits #8842

Cal-L · 2024-03-05T06:18:15Z

Description

The Bitrise E2E check action is currently broken on main. The broken piece is that the check itself isn't re-running after the Bitrise comment is updated. This is because issue_comment doesn't trigger a re-run on the PR itself.

We will see two items appear under Github checks in the PRs.

Run Bitrise E2E Check - which is an action that handles both starting Bitrise E2E tests and checking for build statuses
Bitrise E2E Status - which is a status check that the Run Bitrise E2E Check creates based Bitrise's build status. Depending on the build status, this will either be in a pending, success, or failed state.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-05T06:18:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2024-03-05T06:29:19Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b8a666f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/78c1b778-3dea-4d75-9359-e2c4d3ba62d6

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

codecov-commenter · 2024-03-05T06:29:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (c508446) to head (420b882).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8842   +/-   ##
=======================================
  Coverage   45.51%   45.51%           
=======================================
  Files        1275     1275           
  Lines       31208    31208           
  Branches     3187     3187           
=======================================
+ Hits        14203    14204    +1     
+ Misses      16164    16163    -1     
  Partials      841      841

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-03-13T07:41:59Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 56bc24f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3a70536b-de3c-4b6c-a89b-fe1854733b05

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-03-13T08:47:40Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0ea1640
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1750a4b8-0449-4336-bb00-53a22edcb507

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…trise-custom-status-check

github-actions · 2024-03-19T19:42:46Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0d9204e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d6bb9c68-761a-405d-97fc-fd48aed9203f

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-03-20T20:23:50Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c96e07b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a4cff050-565e-4ff8-87b2-80a66ce7eca0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-03-20T20:49:25Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 420b882
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a58d669-154b-4459-9f33-3bca5011538e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini

AWESOME!! LGTM!

tommasini

LGTM

sonarcloud · 2024-03-20T21:37:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Create pending status for commit

3ec1ef4

Cal-L requested a review from a team as a code owner March 5, 2024 06:18

Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 5, 2024

Add permission to write check

b8a666f

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 5, 2024

Cal-L added 2 commits March 11, 2024 22:24

Consolidate Bitrise GH action

9b85ed1

Temp remove code

748ed1f

Cal-L removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 12, 2024

Cal-L added 10 commits March 11, 2024 22:37

Add permission

a6899af

Remove unused action

ad5e701

Try renaming action

64fe606

Change to pull request target trigger

3f50492

Set skipped status

b4b454a

Update to success status

64f5554

Add conclusion to status check

b6951c5

Fix enum name

ed702b1

Change to complete when skipped

39e9d62

Handle status check based on Bitrise comments

56bc24f

Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 13, 2024

Test with PR ref

0ea1640

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 13, 2024

Cal-L added 2 commits March 13, 2024 08:44

Remove checkout ref

a8d45c3

Remove unused workflows

4ef5812

Cal-L added 2 commits March 19, 2024 08:18

Merge branch 'main' of github.com:MetaMask/metamask-mobile into ci/bi…

2ecb920

…trise-custom-status-check

Merge branch 'main' of github.com:MetaMask/metamask-mobile into ci/bi…

0d9204e

…trise-custom-status-check

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 19, 2024

Improve comments

c96e07b

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 20, 2024

Cal-L added 3 commits March 20, 2024 13:25

Edit Bitrise workflow name

4c1db80

Rename bitrise script

50d291a

Rename bitrise script check

f1313b5

Cal-L changed the title ~~ci: Create pending status for commit~~ ci: Create Bitrise status check for commits Mar 20, 2024

Cal-L added 3 commits March 20, 2024 13:37

Rename bitrise workflow file

777442f

Fix typos

99ec5fd

Merge branch 'main' into ci/bitrise-custom-status-check

420b882

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 20, 2024

tommasini previously approved these changes Mar 20, 2024

View reviewed changes

Cal-L added team-mobile-platform No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Mar 20, 2024

Format bitrise script

d2e1304

Cal-L dismissed tommasini’s stale review via d2e1304 March 20, 2024 21:26

tommasini approved these changes Mar 20, 2024

View reviewed changes

Cal-L merged commit f031748 into main Mar 20, 2024
30 of 31 checks passed

Cal-L deleted the ci/bitrise-custom-status-check branch March 20, 2024 21:38

github-actions bot locked and limited conversation to collaborators Mar 20, 2024

metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Create Bitrise status check for commits #8842

ci: Create Bitrise status check for commits #8842

Cal-L commented Mar 5, 2024 •

edited

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 5, 2024 •

edited by metamaskbot

codecov-commenter commented Mar 5, 2024 •

edited

github-actions bot commented Mar 13, 2024 •

edited by metamaskbot

github-actions bot commented Mar 13, 2024 •

edited by metamaskbot

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

github-actions bot commented Mar 20, 2024 •

edited by metamaskbot

github-actions bot commented Mar 20, 2024 •

edited by metamaskbot

tommasini left a comment

tommasini left a comment

sonarcloud bot commented Mar 20, 2024

ci: Create Bitrise status check for commits #8842

ci: Create Bitrise status check for commits #8842

Conversation

Cal-L commented Mar 5, 2024 • edited

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 5, 2024 • edited by metamaskbot

Bitrise

codecov-commenter commented Mar 5, 2024 • edited

Codecov Report

github-actions bot commented Mar 13, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Mar 13, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Mar 19, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Mar 20, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Mar 20, 2024 • edited by metamaskbot

Bitrise

tommasini left a comment

Choose a reason for hiding this comment

tommasini left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Mar 20, 2024

Quality Gate passed

Cal-L commented Mar 5, 2024 •

edited

github-actions bot commented Mar 5, 2024 •

edited by metamaskbot

codecov-commenter commented Mar 5, 2024 •

edited

github-actions bot commented Mar 13, 2024 •

edited by metamaskbot

github-actions bot commented Mar 13, 2024 •

edited by metamaskbot

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

github-actions bot commented Mar 20, 2024 •

edited by metamaskbot

github-actions bot commented Mar 20, 2024 •

edited by metamaskbot